fix: apply import map during GitHub branch Edge Function bundling#5653
Closed
Tanusree-samanta wants to merge 1 commit into
Closed
fix: apply import map during GitHub branch Edge Function bundling#5653Tanusree-samanta wants to merge 1 commit into
Tanusree-samanta wants to merge 1 commit into
Conversation
Fixes #47000 ShouldUseDenoJsonDiscovery skipped passing --import-map when the import map sat next to the entrypoint, assuming Deno would auto- discover it. This works locally but fails in GitHub branch deploy pipelines where the working directory differs, breaking @backend/ style path aliases. Now we verify the file actually exists before relying on auto-discovery.
Author
|
I've opened a PR that addresses this: [link to your PR] Root cause: |
Contributor
|
Thanks for your contribution. 🙏 This issue has to be handled in our branching service codebase rather than in the CLI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes supabase/supabase#47000
What changed
ShouldUseDenoJsonDiscoverynow checks that the import map fileactually exists before skipping the
--import-mapflagimport map cases
Why
The GitHub branch deploy pipeline runs in a different working
directory than local
supabase functions deploy, so Deno'sauto-discovery of
deno.jsonsilently failed, breaking@backend/style path aliases. This mirrors the explicit resolution already
used locally.
How to test
@backend/aliases resolve correctly